Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gossipsub: Unsubscribe backoff #488

Merged
merged 6 commits into from
Jun 3, 2022
Merged

Gossipsub: Unsubscribe backoff #488

merged 6 commits into from
Jun 3, 2022

Conversation

MarcoPolo
Copy link
Contributor

Implements libp2p/specs#383. There's an open question left in a comment here.

@MarcoPolo MarcoPolo requested a review from vyzo June 1, 2022 23:34
Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!
Left a comment to your question, it should be prune backoff.

gossipsub.go Outdated
// backoff? (instead of always the prune backoff). Aren't we trying
// to figure out the original prune time (expires - backoff), then
// figure out the flood cutoff ((expires - backoff) + floodThreshold)?
// Rust always uses PruneBackoff here. (and I'm not sure if nim handles this: https://github.com/status-im/nim-libp2p/blob/3fdbac49cc5a167673a2bc4b9e1c4b11ca307396/libp2p/protocols/pubsub/gossipsub/behavior.nim#L134
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be prune backoff, we are not unsubscribing, we are pruning.

@MarcoPolo MarcoPolo requested a review from vyzo June 2, 2022 22:41
Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@vyzo vyzo merged commit 68cdae0 into master Jun 3, 2022
@Stebalien Stebalien deleted the marco/unsubscribe-back-off branch August 6, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants