chores: bump go-libp2p #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Wondertan. I'd like to get #555 in since it'll fix this and fix the gossipsub PX. I'm just blocked on debugging a failing test. Should be ready soon |
|
Ah, I didn't realize that #555 contains the bump. I would still split the bump and bug fix in separate PRs, but that's up to you. Close the PR as necessary. |
|
Generally agree. The reason for the exception here is that the fix requires the version bump. That said, we could still do this one first. I'll do that. Thanks again for the PR :) |
MarcoPolo
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps libp2p and resolves Transient -> Limited breaking change