This repository has been archived by the owner on May 26, 2022. It is now read-only.
update quic-go to v0.11.0 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
marten-seemann
force-pushed
the
quic-go-0.11.0
branch
from
37daae6 to
b419deb
Compare
marten-seemann
force-pushed
the
quic-go-0.11.0
branch
from
b419deb to
127b267
Compare
Stebalien
approved these changes
Apr 4, 2019
| return s.Stream.CancelWrite(0) | ||
| s.Stream.CancelRead(0) | ||
| s.Stream.CancelWrite(0) | ||
| return nil |
There was a problem hiding this comment.
Any reason not to return these?
There was a problem hiding this comment.
There’s nothing to return. They don’t have a return value any more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53.
Release-blocker (?) for ipfs/kubo#6163, so we should merge this asap.