Feat/add discovery client #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
requested changes
May 31, 2019
…egistered records. Default TTL for discovery client increased discovery client now utilizes server cookie for added efficiency
vyzo
reviewed
Jun 4, 2019
No problem, I've found that longer names are more self descriptive (and not out of style in comparison to a number of Golang packages) and that with autocomplete they aren't actually a pain. However, I also have no interest in debating variable names as long as they are descriptive enough to get the point across so that interested reviewers can propose new names for them it's a simple approve from me. |
vyzo
reviewed
Jun 20, 2019
discovery.go
Outdated
| } | ||
|
|
||
| type discoveredPeerCache struct { | ||
| cachedRecs map[peer.ID]*record |
There was a problem hiding this comment.
and this just recs, it's a cache and these are named records.
|
@vyzo switched sync.Map with Map + RWMutex like we did in pubsub |
vyzo
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a stateful client that implements the libp2p discovery interface.