This repository has been archived by the owner on May 26, 2022. It is now read-only.
dial: return a nice custom dial error #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
force-pushed
the
feat/improve-errors
branch
from
3a2e78b
to
7e47996
Compare
* Limits the number of dial errors we keep * Exposes the dial errors * Avoids string formatting unless we actually need to. Helps address #119
Stebalien
force-pushed
the
feat/improve-errors
branch
from
7e47996
to
755d063
Compare
raulk
reviewed
Apr 24, 2019
|
|
||
| // TransportError is the error returned when dialing a specific address. | ||
| type TransportError struct { | ||
| Address ma.Multiaddr |
There was a problem hiding this comment.
Would it make sense to save the string representation of the multiaddr to avoid dereferencing and the interface cost? We're likely going to String() the maddr for logging anyway.
There was a problem hiding this comment.
Probably not. The cost of actually formatting the multiaddr will be higher and, hopefully, we'll only do that once anyways.
Really, we should avoid formatting any of this unless debug logging is enabled but that's going to involve ripping out or fixing our current logging framework.
Stebalien
commented
Apr 25, 2019
| connC, dialErr := s.dialAddrs(ctx, p, goodAddrsChan) | ||
| if dialErr != nil { | ||
| logdial["error"] = dialErr.Cause.Error() | ||
| if dialErr.Cause == context.Canceled { |
There was a problem hiding this comment.
This fixes a bug introduced by the multierror patch.
vyzo
approved these changes
Apr 25, 2019
| connC, dialErr := s.dialAddrs(ctx, p, goodAddrsChan) | ||
| if dialErr != nil { | ||
| logdial["error"] = dialErr.Cause.Error() | ||
| if dialErr.Cause == context.Canceled { |
raulk
approved these changes
Apr 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps address #119
Alternative to: #120