This repository has been archived by the owner on May 26, 2022. It is now read-only.
don't call the "connection handler" for outbound connections #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"oops" This was never supposed to happen. Caveat: Fixing this bug may expose other bugs. We need to be very careful here.
gap892003
reviewed
Aug 6, 2020
| // but that should happen much earlier (really, | ||
| // inside the transport and, if not then, during | ||
| // the notifications). | ||
| if h := s.ConnHandler(); h != nil { |
|
We removed the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"oops"
This was never supposed to happen. However, it looks like this has been happening forever. Should we just update the documentation?
If we do that, we should fix the basic host to not call identify from
Connect.