This repository has been archived by the owner on May 26, 2022. It is now read-only.
dialer: handle dial cancel and/or completion before trying new addresses #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Stebalien
commented
Jan 23, 2019
|
|
||
| // We got a result, try again from the top. | ||
| continue | ||
| default: |
There was a problem hiding this comment.
This is a bunch of duplicated code. Not sure if there's a better way.
There was a problem hiding this comment.
The context cancellation check is crucial. Draining responses first before starting more dials is an optimisation, but a welcome one.
Stebalien
force-pushed
the
fix/finish-dial-fast
branch
from
6262685
to
9ed362b
Compare
raulk
approved these changes
Jan 23, 2019
|
|
||
| // We got a result, try again from the top. | ||
| continue | ||
| default: |
There was a problem hiding this comment.
The context cancellation check is crucial. Draining responses first before starting more dials is an optimisation, but a welcome one.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we can continue dialing even if we want to stop.
Note: The dials will all get aborted early so this probably isn't causing any significant performance issues.