New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NATManager should close nmgr.nat #1449

Closed

watjurk opened this issue Apr 25, 2022 · 0 comments · Fixed by #1468

Contributor

watjurk commented Apr 25, 2022

libp2p v0.19.0

When NATManager is closed it does not closes nmgr.nat:

go-libp2p/p2p/host/basic/natmgr.go

Lines 65 to 69 in 5151d4b

    
           func (nmgr *natManager) Close() error { 
        
           	nmgr.ctxCancel() 
        
           	nmgr.refCount.Wait() 
        
           	return nil 
        
           }

When resolving this issue look at #1448, not to fall in the same pitfall

watjurk mentioned this issue

fix natManager to close natManager.nat #1468

Merged

MarcoPolo closed this as completed in #1468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment