Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix natManager to close natManager.nat #1468

Merged
merged 3 commits into from
Jun 15, 2022
Merged

fix natManager to close natManager.nat #1468

merged 3 commits into from
Jun 15, 2022

Conversation

watjurk
Copy link
Contributor

@watjurk watjurk commented Apr 27, 2022

This PR fixes #1449

@watjurk watjurk changed the title fix natManager not closing natManager.nat fix natManager to clos natManager.nat Apr 27, 2022
Stebalien
Stebalien requested changes May 3, 2022
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

p2p/host/basic/natmgr.go Outdated Show resolved Hide resolved
p2p/host/basic/natmgr.go Show resolved Hide resolved
@BigLep BigLep changed the title fix natManager to clos natManager.nat fix natManager to close natManager.nat May 27, 2022
@MarcoPolo MarcoPolo self-requested a review May 27, 2022 16:45
MarcoPolo
MarcoPolo requested changes Jun 3, 2022
View reviewed changes
Copy link
Collaborator

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move close logic to defer in background. Thank you!

@watjurk watjurk requested a review from MarcoPolo June 7, 2022 09:10
MarcoPolo
MarcoPolo approved these changes Jun 15, 2022
View reviewed changes
Copy link
Collaborator

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MarcoPolo MarcoPolo merged commit 8840285 into libp2p:master Jun 15, 2022
MarcoPolo pushed a commit that referenced this pull request Jun 24, 2022
@watjurk @MarcoPolo
fix natManager to close natManager.nat (#1468)
639b9a6 
* rename natManager.natnatmu to follow the standard

* fix natManager to close natManager.nat

* natmgr: move close to defer in background
@MarcoPolo MarcoPolo mentioned this pull request Jul 7, 2022
Closed
41 tasks
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
Closed
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien requested changes

@MarcoPolo MarcoPolo MarcoPolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
go-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NATManager should close nmgr.nat
3 participants
@watjurk @Stebalien @MarcoPolo