Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libp2p spec link in CONTRIBUTE is a broken link. #41

Closed
mjgarton opened this issue Apr 25, 2016 · 2 comments
Closed

libp2p spec link in CONTRIBUTE is a broken link. #41

mjgarton opened this issue Apr 25, 2016 · 2 comments
Assignees
@daviddias
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue

Comments

@mjgarton
Copy link

No description provided.

@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Sep 14, 2016
hackergrrl pushed a commit to hackergrrl/go-libp2p that referenced this issue Sep 15, 2016
@noffle
Fix libp2p spec link
c9281c4 
Addresses libp2p#41
@hackergrrl hackergrrl mentioned this issue Sep 15, 2016
Merged
@ghost ghost added status/deferred Conscious decision to pause or backlog and removed status/deferred Conscious decision to pause or backlog labels Nov 12, 2016
@Kubuxu Kubuxu added the status/deferred Conscious decision to pause or backlog label Nov 28, 2016
@daviddias
Copy link
Member

Fixed with #216 and also a lot more documentation to come :)

@daviddias daviddias self-assigned this Aug 19, 2017
@daviddias daviddias added the exp/novice Someone with a little familiarity can pick up label Aug 19, 2017
@VMois
Copy link

VMois commented Aug 30, 2018

I think you can close this issue. #216 is already merged and link is working.

@ghost ghost removed the status/deferred Conscious decision to pause or backlog label Aug 30, 2018
marten-seemann pushed a commit that referenced this issue Apr 22, 2022
@Stebalien
Merge pull request #41 from libp2p/fix/modernize
e1669e2 
modernize request handling
marten-seemann added a commit that referenced this issue Apr 22, 2022
@marten-seemann
Merge pull request #41 from libp2p/reduce-streams
c0a8ac8 
reduce the number of max incoming stream to 256
marten-seemann pushed a commit that referenced this issue Apr 27, 2022
@Stebalien
Merge pull request #41 from libp2p/fix-staticcheck
fd9610c 
fix staticcheck
marten-seemann added a commit that referenced this issue May 18, 2022
@marten-seemann
disable failing TestV6V4 on OSX (#41)
c42772b
@MarcoPolo MarcoPolo mentioned this issue Jul 7, 2022
Closed
41 tasks
marten-seemann pushed a commit that referenced this issue Aug 9, 2022
@raulk
Merge pull request #41 from libp2p/fix/smaller-addr-book
0b11d14 
store expiring addrs by pointer
marten-seemann added a commit that referenced this issue Aug 15, 2022
@marten-seemann
add a DefaultLimitConfig with infinite limits (#41)
6e563a8 
This is useful when recording a trace to observe the baseline resource
consumption.
marten-seemann pushed a commit that referenced this issue Aug 17, 2022
@Stebalien
Merge pull request #41 from Jun10ng/master
264c2e7 
Correct a typo
marten-seemann pushed a commit that referenced this issue Aug 17, 2022
@lidel
feat: support encoding/decoding peer IDs as CIDs in text (#41)
fe9fc6f 
What:

1. Supports decoding CIDs (of libp2p keys) as peer IDs 
   (libp2p/specs#216)
2. Continues to encode peer IDs as base58 multihashes by default.
3. Adds functions for converting between peer IDs and CIDs.
4. Deprecates IDB58{Decode,Encode}, replacing them with {Decode,Encode}.

Why:

1. We _need_ to support multibase somehow, so we can put peer IDs in domains.
2. This makes peer IDs fully self describing. That is, the CID itself indicates that it's a hash of a libp2p public key.
3. It's much easier to upgrade wire protocols than text. This change punts
pids-as-cids on the wire down the road but that's something we can revisit if it ever becomes relevant. 

See libp2p/specs#111 for context.

Deviations from that issue:

* This _retains_ the current peer ID inlining of ed25519 keys. That turned out to be a nightmare, one I'd like to punt a bit more down the road.
* Likewise, this _punts_ the question of embedding the multi-hash algorithm in the public key.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daviddias daviddias

Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Stebalien @daviddias @whyrusleeping @Kubuxu @mjgarton @VMois