-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle /quic
and /ws
in NAT mappings
#428
Comments
@Stebalien Did you mean that |
But we do want to open port mappings in this case too. |
just like:
|
No. We actually can't listen on both The issue is much simpler:
This means that even though we might be listening on |
that's definitely a bug! |
1. Update to work with libp2p/go-libp2p-nat#14. 2. Avoid observed addrs when our NAT tells us about external addrs. 3. Ignore bad addrs reported by our NAT. Substitute with observed addrs. 4. Fix #428.
1. Update to work with libp2p/go-libp2p-nat#14. 2. Avoid observed addrs when our NAT tells us about external addrs. 3. Ignore bad addrs reported by our NAT. Substitute with observed addrs. 4. Fix #428.
1. Update to work with libp2p/go-libp2p-nat#14. 2. Avoid observed addrs when our NAT tells us about external addrs. 3. Ignore bad addrs reported by our NAT. Substitute with observed addrs. 4. Fix #428.
1. Update to work with libp2p/go-libp2p-nat#14. 2. Avoid observed addrs when our NAT tells us about external addrs. 3. Ignore bad addrs reported by our NAT. Substitute with observed addrs. 4. Fix #428.
1. Update to work with libp2p/go-libp2p-nat#14. 2. Avoid observed addrs when our NAT tells us about external addrs. 3. Ignore bad addrs reported by our NAT. Substitute with observed addrs. 4. Fix #428.
The mappings report
/ip{4,6}/.../{udp,tcp}/...
without the/quic
or/ws
suffix. This means that, while we do map these protocols, we don't actually advertise the correct addresses.We need to:
BasicHost.AllAddrs
to pick the right mappings based on the internal port, not the full address.go-libp2p-nat
to only accept tcp/udp addresses (quic, ws, etc. don't make any sense at the NAT level anyways). Really, we may want to switch the interfaces to protocol + port instead of multiaddr but we can do that later.The text was updated successfully, but these errors were encountered: