Use circuitv2 code #1183
Merged
Use circuitv2 code #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
approved these changes
Sep 10, 2021
| } else { | ||
| _ = relay.NewAutoRelay(ctx, h, discovery, router, cfg.StaticRelays) | ||
| } | ||
| _ = relay.NewAutoRelay(ctx, h, discovery, router, cfg.StaticRelays) |
There was a problem hiding this comment.
I like this. This will make it a lot easier to implement a Close method here, and not rely on the ctx any more.
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the (backwards compatible) circuit v2 client for handling relay connections.
Relay options are removed; relay servers should be explicitly instantiated or use a dedicated daemon (e.g. p2pd or relayd).
Also moves the
circuitv2code intop2p/protocol(see #1177)