Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow the ping protocol on transient connections #1244

Merged
merged 1 commit into from
Nov 23, 2021
Merged

allow the ping protocol on transient connections #1244

merged 1 commit into from
Nov 23, 2021

Conversation

marten-seemann
Copy link
Contributor

No description provided.

lidel
lidel approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, iiuc this should allow us to ping peers over /p2p-circuit/ addrs 🙏

@marten-seemann marten-seemann merged commit 838220f into master Nov 23, 2021
@marten-seemann marten-seemann deleted the allow-ping-on-transient-connections branch November 30, 2021 14:17
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
Closed
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

@vyzo vyzo Awaiting requested review from vyzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marten-seemann @lidel