tls: fix flaky TestInvalidCerts on Windows #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we can't reliably establish a few TCP connections in short succession.
marten-seemann
force-pushed
the
tls-invalid-certs-error
branch
from
8ab14d6
to
ce5ff06
Compare
|
@MarcoPolo This is ready for review now. |
marten-seemann
changed the title
MarcoPolo
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1529.
The amount of trivial things that simply don't work reliably on Windows is mind blowing. Absolutely incredible.
This PR should not work around those and make the TLS tests pass on Windows.