pstoremanager: fix test timeout #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| time.Sleep(10 * time.Millisecond) // make sure the event is sent before we close | ||
|
|
||
| // make sure the event is sent before we close | ||
| <-sub.Out() |
There was a problem hiding this comment.
Should we have a select with a timeout here?
There was a problem hiding this comment.
So that this times out before the test times out? Does it really matter? It's a bit annoying to add the select with a timeout. Maybe the marginal benefit of having CI fail after waiting for 10s is better than waiting to fail after 10m.
I'm less convinced. For me, if CI is longer than 3m I'm already not going to page back on the order of minutes.
But I don't feel strongly about this so I'll change.
There was a problem hiding this comment.
Also don’t feel strongly. I generally prefer it because the error message is nicer.
marten-seemann
approved these changes
Jun 2, 2022
MarcoPolo
added a commit
that referenced
this pull request
Jun 24, 2022
* Wait for event to be sent before we close * Add timeout on channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1585 by actually making sure the event is sent before we close, instead of waiting and expecting the event to be sent by then.