chore: update core dep #1641
Merged
chore: update core dep #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MarcoPolo
commented
Jul 5, 2022
•
MarcoPolo
commented
- Upgrades rcmgr and core by a patch release
- Dowgrades grpc indirect dep to avoid breaking downstream users unnecessarily (see: Broken grpc.WithBalancerName weaveworks/common#239)
- removed btcd dep
go.mod
Outdated
| @@ -110,7 +108,7 @@ require ( | |||
| golang.org/x/net v0.0.0-20220630215102-69896b714898 // indirect | |||
| golang.org/x/tools v0.1.11 // indirect | |||
| golang.org/x/xerrors v0.0.0-20220609144429-65e65417b02f // indirect | |||
| google.golang.org/grpc v1.47.0 // indirect | |||
| google.golang.org/grpc v1.36.0 // indirect | |||
There was a problem hiding this comment.
What made us update this dependency since the v0.20.0 release? In v0.20.0 we were using v1.31.1.
There was a problem hiding this comment.
You updated this in this pr: https://github.com/libp2p/go-libp2p/pull/1634/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R113
I think I picked 1.36 by looking at the go mod graph.
There was a problem hiding this comment.
Actually we can get rid of grpc dep completely. Need this first: libp2p/go-libp2p-testing#63
marten-seemann
approved these changes
Jul 7, 2022
| @@ -110,7 +108,6 @@ require ( | |||
| golang.org/x/net v0.0.0-20220630215102-69896b714898 // indirect | |||
| golang.org/x/tools v0.1.11 // indirect | |||
| golang.org/x/xerrors v0.0.0-20220609144429-65e65417b02f // indirect | |||
| google.golang.org/grpc v1.47.0 // indirect | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.