Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autorelay: flaky: bump timeout in CI for flaky test #1801

Merged
merged 1 commit into from
Oct 6, 2022
Merged

autorelay: flaky: bump timeout in CI for flaky test #1801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion p2p/host/autorelay/autorelay_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package autorelay_test

import (
"context"
"os"
"strings"
"sync/atomic"
"testing"
Expand Down Expand Up @@ -400,11 +401,18 @@ func TestMaxAge(t *testing.T) {
require.Eventually(t, func() bool { return numRelays(h) > 0 }, 3*time.Second, 100*time.Millisecond)
relays := usedRelays(h)
require.Len(t, relays, 1)

waitFor := 500 * time.Millisecond
tick := 100 * time.Millisecond
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this doesn't need to be a variable. (I don't feel strongly about this, feel free to merge)

if os.Getenv("CI") != "" {
// Only increase the waitFor since we are increasing the mock clock every tick.
waitFor *= 10
}
require.Eventually(t, func() bool {
// we don't know exactly when the timer is reset, just advance our timer multiple times if necessary
cl.Add(time.Second)
return len(peerChans) == 0
}, 500*time.Millisecond, 100*time.Millisecond)
}, waitFor, tick)

cl.Add(10 * time.Minute)
for _, r := range relays2 {
Expand Down