webtransport: use the rcmgr to control flow control window increases #1832
Conversation
marten-seemann
force-pushed
the
webtransport-rcmgr
branch
4 times, most recently
from
b421e7f
to
0eb8dbd
Compare
| @@ -60,7 +60,18 @@ func (c *conn) AcceptStream() (network.MuxedStream, error) { | |||
| return &stream{str}, nil | |||
| } | |||
|
|
|||
| func (c *conn) Close() error { return c.session.Close() } | |||
| func (c *conn) allowWindowIncrease(size uint64) bool { | |||
| return c.scope.ReserveMemory(int(size), network.ReservationPriorityMedium) == nil | |||
There was a problem hiding this comment.
What's the argument for Medium vs High? Medium bounds us to 60% of available memory. So a 4GiB node with defaults would have 0.6(512+128MiB)=384MiB here. I think that sounds fine, just want to check though
There was a problem hiding this comment.
When we're running low on memory, we want to block allocations that are not strictly necessary. Performance will be slightly degraded if you don't get the full receive window, but things will still work. Whereas if you fail to allocate the buffer needed for parsing a protobuf (for example), things will break in a lot worse ways.
|
|
||
| proxy, err := quicproxy.NewQuicProxy("localhost:0", &quicproxy.Opts{ | ||
| RemoteAddr: ln.Addr().String(), | ||
| DelayPacket: func(quicproxy.Direction, []byte) time.Duration { return rtt / 2 }, |
| for { | ||
| _, err := str.Write(bytes.Repeat([]byte{0x42}, 1<<10)) | ||
| require.NoError(t, err) | ||
| if atomic.LoadUint32(&increasesDone) > 0 { |
There was a problem hiding this comment.
nit: maybe easier to use a select over a done semaphore?
| if atomic.LoadUint32(&increasesDone) > 0 { | |
| select { | |
| case <-increasesDone: | |
| return | |
| default: | |
| } |
There was a problem hiding this comment.
This will be nicer once we can use the atomic.Bool that was introduced in Go 1.19: https://pkg.go.dev/sync/atomic#Bool.
marten-seemann
force-pushed
the
webtransport-rcmgr
branch
from
0eb8dbd
to
43a44ec
Compare
marten-seemann
force-pushed
the
webtransport-rcmgr
branch
from
43a44ec
to
b50b460
Compare
Fixes #1826.
Depends on quic-go/webtransport-go#35.