Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: fix flaky TestHandshakeConnectionCancellations test #1896

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

marten-seemann
Copy link
Contributor

Explanation:

// crypto/tls' cancellation logic works by spinning up a separate Go routine that watches the ctx.
// If the ctx is canceled, it kills the handshake.
// We need to make sure that the handshake doesn't complete before that Go routine picks up the cancellation.

@marten-seemann marten-seemann force-pushed the fix-flaky-tls-handshake-cancellation-test branch from 9a86958 to c02f8b2 Compare November 17, 2022 04:17
@marten-seemann marten-seemann merged commit 683bc67 into master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants