transport.Listener,quic: Support multiple QUIC versions with the same Listener. Only return a single multiaddr per listener. #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
changed the title
MarcoPolo
force-pushed
the
marco/1904
branch
from
631fa8b
to
17ae32f
Compare
MarcoPolo
force-pushed
the
marco/1904
branch
from
67c939c
to
56ad201
Compare
marten-seemann
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
LGTM modulo the review comments here.
Can you add some tests similar to the one suggested in #1904 (comment) in p2p/test:
- create a draft-29 listener and check that a draft-29 connection is accepted, but a v1 connection is closed
- the other way round, for a v1 listener
- create a draft-29 + v1 listener and check that both versions are accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1904
Undoes part of the work in #1881. The QUIC transport now returns a virtual listener that only handles one QUIC version. If a user then listens on another QUIC version with the same multiaddr, we return another virtual listener that uses the same underlying listener but only advertises the other QUIC version.
This is ready for review, but I see some flakiness in the tests (maybe also from #1905 ) so I'll continue debugging that.