Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webtransport: disable support for signed/static TLS certificates #1927

Merged
merged 1 commit into from
Dec 5, 2022
Merged

webtransport: disable support for signed/static TLS certificates #1927

merged 1 commit into from
Dec 5, 2022

Conversation

MarcoPolo
Copy link
Collaborator

This needs more thought before we enable support.

@MarcoPolo MarcoPolo force-pushed the marco/no-signed-cert-support-webtransport branch from 0bfbdaf to 42b7c59 Compare December 1, 2022 22:31
marten-seemann
marten-seemann approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we t.Skip the tests instead of deleting them? We do want this feature at some point in the future.

It would probably also makes sense to create an issue in this repo, and include a link in the error message and in the skip message.

@p-shahi
Copy link
Member

p-shahi commented Dec 5, 2022

Is this needed in #1766

@marten-seemann marten-seemann mentioned this pull request Dec 5, 2022
Closed
34 tasks
@marten-seemann
Copy link
Contributor

Yes.

@MarcoPolo
Copy link
Collaborator Author

If we use t.Skip we have to make changes since we removed the WithTLSConfig option. So I removed them. I think it's pretty easy to revive dead code from the git history, so I would prefer to keep it deleted and revive it when needed.

@MarcoPolo MarcoPolo force-pushed the marco/no-signed-cert-support-webtransport branch from 42b7c59 to 9fcaaae Compare December 5, 2022 20:49
@MarcoPolo MarcoPolo merged commit 5d22740 into master Dec 5, 2022
@MarcoPolo MarcoPolo mentioned this pull request Mar 29, 2023
Open
zvolin added a commit to zvolin/go-libp2p that referenced this pull request Nov 10, 2023
@zvolin
feat: reenable webtransport support removed in libp2p/pull/1927
25cb621
zvolin added a commit to zvolin/go-libp2p that referenced this pull request Nov 10, 2023
@zvolin
feat: reenable webtransport support removed in libp2p/pull/1927
cf9d684
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
go-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcoPolo @p-shahi @marten-seemann