webtransport: fix flaky accept queue test #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
fix-webtransport-accept-queue-test
branch
from
fe5a7c6
to
32abb4f
Compare
marten-seemann
force-pushed
the
fix-webtransport-accept-queue-test
branch
from
6f91520
to
7475114
Compare
marten-seemann
force-pushed
the
fix-webtransport-accept-queue-test
branch
2 times, most recently
from
61f2639
to
386ef33
Compare
marten-seemann
force-pushed
the
fix-webtransport-accept-queue-test
branch
3 times, most recently
from
39a9d9f
to
42d7aa0
Compare
MarcoPolo
approved these changes
Dec 9, 2022
marten-seemann
force-pushed
the
fix-webtransport-accept-queue-test
branch
from
42d7aa0
to
7a53d58
Compare
MarcoPolo
approved these changes
Dec 9, 2022
marten-seemann
force-pushed
the
fix-webtransport-accept-queue-test
branch
from
7a53d58
to
df1f325
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1870.
The problem here is that it's not valid assumption that the 16 connection we dial first are all accepted (by the QUIC listener) in that order.
What we should assert that out of 17 connections dialed, 16 are accepted and 1 is rejected.