Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to test-plan composite action #2039

Merged

Conversation

thomaseizinger
Copy link
Contributor

I wasn't sure if you wanted to keep the Makefile. I deleted it for now because we no longer create an archive. Feel free to take over to fix up any additional things.

@thomaseizinger
Copy link
Contributor Author

I love Rust but I am jealous that you can build a go-libp2p application without any caching in a new docker container in less than a minute: https://github.com/libp2p/go-libp2p/actions/runs/4069702343/jobs/7009727962#step:3:59

@MarcoPolo
Copy link
Collaborator

And it's statically linked! Go tooling is quite nice.

@MarcoPolo MarcoPolo merged commit a5d4b2b into libp2p:master Feb 2, 2023
@thomaseizinger
Copy link
Contributor Author

Is this an optimized binary or a debug build? We are currently running release builds in the tests but they take even longer so I am thinking of switching to debug builds unless we really need the absolute best performance.

@MarcoPolo
Copy link
Collaborator

This is a release build. Debug should be fine. Most of the overhead is in the container namespacing and networking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants