Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: add no alloc metrics for eventbus, swarm, identify #2108

Merged
merged 2 commits into from
Feb 17, 2023
Merged

metrics: add no alloc metrics for eventbus, swarm, identify #2108

merged 2 commits into from
Feb 17, 2023

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Feb 16, 2023 •
edited
Loading

Fixes: #2060

@sukunrt sukunrt changed the title add no alloc metrics for eventbus metrics: add no alloc metrics for eventbus, swarm, identify Feb 16, 2023
@sukunrt sukunrt marked this pull request as ready for review February 16, 2023 11:28
@marten-seemann
Copy link
Contributor

Tests seem to be failing:

  === RUN   TestMetricsNoAllocNoCover
      metrics_test.go:27: Alloc Test: IdentifyPush, got: 14.00, expected: 0 allocs
  --- FAIL: TestMetricsNoAllocNoCover (0.04s)

Do you need to use the nocover built flag as in #2044?

@sukunrt
Copy link
Member Author

sukunrt commented Feb 17, 2023

sorry. my bad. I didn't realise that these tests would need to be skipped when all the tests are being run. fixed it now.

@marten-seemann marten-seemann merged commit 9f12163 into libp2p:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

swarm: Add NoAlloc test to swarm metrics
2 participants
@sukunrt @marten-seemann