swarm: add early muxer selection to swarm metrics #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
early-muxer-tracking
branch
from
360742e
to
1235885
Compare
|
Please update the Changelog.md file in this section with these changes https://github.com/libp2p/go-libp2p/blob/master/CHANGELOG.md#additional-metrics- |
core/network/conn.go
Outdated
| @@ -43,6 +43,8 @@ type ConnectionState struct { | |||
| Security protocol.ID | |||
| // the transport used on this connection. For example: tcp | |||
| Transport string | |||
| // indicates whether StreamMultiplexer was selected using inlined muxer negotiation | |||
| EarlyMuxerSelection bool | |||
There was a problem hiding this comment.
Suggested change
| EarlyMuxerSelection bool | |
| UsedEarlyMuxerNegotiation bool |
p2p/net/upgrader/conn.go
Outdated
| security protocol.ID | ||
| muxer protocol.ID | ||
| security protocol.ID | ||
| earlyMuxerSelection bool |
There was a problem hiding this comment.
Suggested change
| earlyMuxerSelection bool | |
| usedEarlyMuxerNegotiation bool |
| @@ -1059,6 +1059,139 @@ | |||
| "title": "Connection Duration", | |||
| "type": "timeseries" | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
The latency graphs are not very useful, at least on my node. Not really sure how to fix it though.
Would it make more sense to just use a pie chart here, and show the fraction of early muxer negotiation?
sukunrt
force-pushed
the
early-muxer-tracking
branch
from
ea699ff
to
21bf54d
Compare
marten-seemann
approved these changes
Feb 22, 2023
| @@ -1059,6 +1059,139 @@ | |||
| "title": "Connection Duration", | |||
| "type": "timeseries" | |||
| }, | |||
| { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2021