swarm: remove parallel tests from swarm tests #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -552,7 +538,7 @@ func newSilentListener(t *testing.T) ([]ma.Multiaddr, net.Listener) { | |||
| } | |||
|
|
|||
| func TestDialSimultaneousJoin(t *testing.T) { | |||
| const dialTimeout = 250 * time.Millisecond | |||
| const dialTimeout = 3 * time.Second | |||
There was a problem hiding this comment.
Is this necessary? This one test now takes 3s.
There was a problem hiding this comment.
Yes. I'm pretty sure I saw this test flake here because of the dialTimeout. 1s might be okay as well but 3s definitely is.
There was a problem hiding this comment.
Fine for now, but long term, we'll need to find a faster solution for this.
There was a problem hiding this comment.
There's much much lower hanging fruit than this.
- We can use a build cache
- We can split the 32bit tests/race tests into a separate job so they can run in parallel. With a build cache, these won't waste too much time in duplicated efforts.
marten-seemann
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing these tests in parallel causes flakiness in CI.