identify: set stream deadlines for Identify and Identify Push streams #2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
approved these changes
Jun 19, 2023
dennis-tra
reviewed
Jun 19, 2023
marten-seemann
force-pushed
the
identify-timeouts
branch
from
8fdd3ee
to
1abdae4
Compare
MarcoPolo
pushed a commit
that referenced
this pull request
Jun 19, 2023
MarcoPolo
pushed a commit
that referenced
this pull request
Jun 19, 2023
MarcoPolo
added a commit
that referenced
this pull request
Jun 19, 2023
* fix: in the swarm move Connectedness emit after releasing conns (#2373) * fix: in the swarm move Connectedness emit after releasing conns go-libp2p-kad-dht now listen to both EvtPeerIdentificationCompleted and EvtPeerConnectednessChanged and EvtPeerIdentificationCompleted calls .ConnsToPeer inorder to do some filtering. However it happens that it deadlocks because if the swarm is trying to emit a EvtPeerConnectednessChanged while the subscriber is trying to process an EvtPeerIdentificationCompleted, the subscriber is stuck on s.conns.RLock() while the swarm wont release it before having sent EvtPeerConnectednessChanged. Deadlock ! I havn't confirmed this fixes my bug given this takes time to reproduce, I'll startup a new experiment soon. * Fix other deadlock and add a test * Make test a little faster * Bind on localhost --------- Co-authored-by: Marco Munizaga <git@marcopolo.io> * Release version v0.27.7 * identify: set stream deadlines for Identify and Identify Push streams (#2382) --------- Co-authored-by: Jorropo <jorropo.pgm@gmail.com> Co-authored-by: Marten Seemann <martenseemann@gmail.com>
marten-seemann
added a commit
that referenced
this pull request
Jun 20, 2023
marten-seemann
added a commit
that referenced
this pull request
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2379.