Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop support for go1.20 #2708

Merged
merged 5 commits into from
Feb 18, 2024
Merged

chore: drop support for go1.20 #2708

merged 5 commits into from
Feb 18, 2024

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Feb 16, 2024

No description provided.

@sukunrt sukunrt changed the title ci: run for go1.22 chore: drop support for go1.20 Feb 16, 2024
@sukunrt sukunrt marked this pull request as ready for review February 16, 2024 17:58
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, go 1.20 still "works", it'll just use a slower sha implementation. Which is fine, IMO.

@@ -10,9 +10,10 @@ import (
"io"
"math/big"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@@ -8,9 +8,10 @@ import (
"errors"
"io"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@@ -5,11 +5,12 @@ import (
"fmt"
"testing"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@@ -10,10 +10,11 @@ import (
"runtime/debug"
"time"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@sukunrt sukunrt merged commit c8024ff into master Feb 18, 2024
9 checks passed
@sukunrt sukunrt mentioned this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants