Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magiselect #2737

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Magiselect #2737

wants to merge 4 commits into from

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Mar 17, 2024

Implements libp2p/specs#608 for /tls and /noise.

Todo:

  • Fix existing tests.
  • Add new tests.
  • Improve maddr reachability extension computation (generalize reachable quic into reachable quic + webtransport into reachable a into reachable a + b).
  • Spec
  • Figure out 8962b2a's situation
  • Favor /tls over /noise over multistream-select in happy eyeballs.

@Jorropo
Copy link
Contributor Author

Jorropo commented Mar 17, 2024

It might be worth completely reworking the transport pipeline to be bottom up instead of top down (so tls, noise, multiselect and websocket would all receive the tcp transport instead of the other way around).
But that a way bigger refactor.

@@ -36,7 +36,7 @@ require (
github.com/multiformats/go-base32 v0.1.0
github.com/multiformats/go-multiaddr v0.12.2
github.com/multiformats/go-multiaddr-dns v0.3.1
github.com/multiformats/go-multiaddr-fmt v0.1.0
github.com/multiformats/go-multiaddr-fmt v0.1.1-0.20240317044316-238036a861f0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant