-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix address filtering for /ip6, add tests #36
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Lars Gierth <larsg@systemli.org>
Fixed the tests |
if err != nil { | ||
// if we cant parse it, its probably not blocked | ||
return false | ||
} | ||
netip := net.ParseIP(netaddr.String()) | ||
if netip == nil { | ||
return false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right now these filters are ip-specific. in the future we may want to express filters of other kinds (like tcp ports, etc)
LGTM. @whyrusleeping ? |
ghost
mentioned this pull request
Apr 12, 2016
yeah, LGTM |
Thanks for that. |
marten-seemann
pushed a commit
that referenced
this pull request
Dec 20, 2021
marten-seemann
pushed a commit
that referenced
this pull request
Dec 20, 2021
* Single goroutine managing autonat-relevent events. * Watching incoming connections and local interface changes as signals. * Emit a single 'rechabilitychanged' persistent event fix #40 fix #36 fix #35 fix #34 fix #11 obsolete #28 obsolete #9 Co-authored-by: Aarsh Shah <aarshkshah1992@gmail.com> Co-authored-by: Adin Schmahmann <adin.schmahmann@gmail.com>
marten-seemann
pushed a commit
that referenced
this pull request
Jan 17, 2022
Add peer protection capability (implementation)
marten-seemann
pushed a commit
that referenced
this pull request
Apr 21, 2022
Fix address filtering for /ip6, add tests
marten-seemann
pushed a commit
that referenced
this pull request
Apr 21, 2022
use optimized 'HaveConnToPeer' checks
marten-seemann
pushed a commit
that referenced
this pull request
Apr 22, 2022
set linger to 0 for both inbound and outbound connections
marten-seemann
added a commit
that referenced
this pull request
Apr 26, 2022
* use the new SecureTransport and SecureMuxer interfaces * restore sanity check for the remote peer's ID, add log statement
marten-seemann
pushed a commit
that referenced
this pull request
Apr 26, 2022
Rename protobuf fields in handshake payload
marten-seemann
pushed a commit
that referenced
this pull request
Aug 9, 2022
Adapt peerstore for ds.NewTransaction() now returning error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Lars Gierth larsg@systemli.org