fix panic in observed address activation check #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
The activated check cleans up, which leads to panics with concurrent reads. This moves the seenBy set clean up into gc, where it belongs
whyrusleeping
approved these changes
Apr 9, 2019
Stebalien
added a commit
to ipfs/kubo
that referenced
this pull request
Apr 9, 2019
Fixes a panic in identify's observed address handling. libp2p/go-libp2p#586 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
hannahhoward
pushed a commit
to filecoin-project/kubo-api-client
that referenced
this pull request
Jun 19, 2023
Fixes a panic in identify's observed address handling. libp2p/go-libp2p#586 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The activated check cleans up, which leads to panics with concurrent reads.
This moves the seenBy set clean up into gc, where it belongs