Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix SetDeadline error conditions #59

Merged
merged 1 commit into from
May 22, 2019
Merged

fix SetDeadline error conditions #59

merged 1 commit into from
May 22, 2019

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented May 22, 2019

No description provided.

@vyzo vyzo requested a review from Stebalien May 22, 2019 21:21
Stebalien
Stebalien approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd also be fine just not returning an error and doing nothing. Technically, the deadline did "work", it's just useless.

@vyzo vyzo merged commit 8df7f3d into master May 22, 2019
@vyzo vyzo deleted the fix/set-deadline branch May 22, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyzo @Stebalien