Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support WASM #54

Merged
merged 2 commits into from
Dec 28, 2018
Merged

Support WASM #54

merged 2 commits into from
Dec 28, 2018

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Dec 23, 2018

"Compiles Successfully"

For ipfs/kubo#5694

@ghost ghost assigned magik6k Dec 23, 2018
@ghost ghost added the status/in-progress In progress label Dec 23, 2018
@magik6k magik6k mentioned this pull request Dec 23, 2018
Open
Stebalien
Stebalien requested changes Dec 26, 2018
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a wasm-only build flag, I think.

@magik6k
Copy link
Contributor Author

magik6k commented Dec 28, 2018

Upgrading Go version in Travis seems to have helped

@Stebalien
Copy link
Member

Ah, I see. 1.10 didn't support WASM.

@Stebalien Stebalien merged commit f92c31f into master Dec 28, 2018
@Stebalien Stebalien deleted the feat/wasm branch December 28, 2018 18:09
@ghost ghost removed the status/in-progress In progress label Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees

@magik6k magik6k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magik6k @Stebalien