-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create config automatically if not provided #151
feat: create config automatically if not provided #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self review
https://stackoverflow.com/questions/47819464/where-to-save-configuration-data-files-on-gnu-linux suggests storing config under
|
Will update
Maybe |
|
Also, let's use jsonc-parser or some other
We're already squatting on the binary name, so just |
FYI @achingbrain we do have |
Oh yeah, maybe we'd be better internet citizens if we did that. If we use the module name then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self review
I think this is a good idea. I imagine that most users of this are coming from js-libp2p, for which it would more intuitive to follow js-libp2p config naming. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self review
@achingbrain @2color this is ready for review again: merged from main and updated config to use js-libp2p config keys. One non-normal item in the config is the identity property |
}, | ||
bootstrap: { | ||
list: [ | ||
'/dns4/am6.bootstrap.libp2p.io/tcp/443/wss/p2p/QmbLHAnMoJPWSCR5Zhtx6BHJX9KiKNN6tpvbUcqanj75Nb', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add the full list of defaults also used by Helia:
'/dnsaddr/bootstrap.libp2p.io/p2p/QmNnooDu7bfjPFoTZYxMNLWUQJyrVwtbZg5gBMjTezGAJN',
'/dnsaddr/bootstrap.libp2p.io/p2p/QmbLHAnMoJPWSCR5Zhtx6BHJX9KiKNN6tpvbUcqanj75Nb',
'/dnsaddr/bootstrap.libp2p.io/p2p/QmcZf59bWwK5XFi76CZX8cbJ4BhTzzA3gU1ZjYZcYW3dwt',
// va1 is not in the TXT records for _dnsaddr.bootstrap.libp2p.io yet
// so use the host name directly
'/dnsaddr/va1.bootstrap.libp2p.io/p2p/12D3KooWKnDdG3iXw9eTFijk3EWSunZcFi54Zka4wmtqtt6rPxc8',
'/ip4/104.131.131.82/tcp/4001/p2p/QmaCpDMGvV2BGHeYERUEnRQAwe3N8SzbUtfsmvsqQLuvuJ'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in #201
and remove from config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I took the liberty of pushing some small fixes. Overall, looks great and makes it much easier to run without much prior knowledge, |
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Title
feat: create config automatically if not provided
Description
--config
is not provided when starting up.~/.config/amino
directory for storing configuration filesNotes & open questions
~/.config/amino
as the root. may update further?Change checklist