This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
refactor: callbacks -> async/await #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: All places in the API that used callbacks are now replaced with async/await
vasco-santos
suggested changes
Mar 26, 2019
alanshaw
reviewed
Jul 15, 2019
alanshaw
approved these changes
Jul 15, 2019
added 2 commits
July 15, 2019 09:13
|
@dirkmc can you fix the cov so we can now get this merged? |
|
I'm not sure how to read these codecov numbers. It looks like coverage has increased 10.21% but somehow codecov/patch is at 75%? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: All places in the API that used callbacks are now replaced with async/await
Depends on: