Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: replace err-code with CodeError #13

Merged
merged 3 commits into from
Mar 22, 2023
Merged

fix!: replace err-code with CodeError #13

merged 3 commits into from
Mar 22, 2023

Conversation

tabcat
Copy link
Contributor

@tabcat tabcat commented Mar 21, 2023

Related: libp2p/js-libp2p#1269

  • deps: install @libp2p/interfaces

  • fix!: replace err-code with CodeError
    The decrypt method used err-code to expose missingKeys on error.
    CodeError's interface differs from err-code in how it exposes props:

    props = { missingKeys }
    errCode.missingKeys // props are merged with the Error
    CodeError.props.missingKeys // props are namespaced
  • deps: remove err-code

tabcat added 3 commits March 21, 2023 13:06
BREAKING CHANGE

The decrypt method used err-code to expose missingKeys on error.
CodeError's interface differs from err-code in how it exposes props:

```js
props = { missingKeys }
errCode.missingKeys // props are merged with the Error
CodeError.props.missingKeys // props are namespaced
```
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maschad maschad merged commit 957f2f6 into libp2p:main Mar 22, 2023
github-actions bot pushed a commit that referenced this pull request Mar 22, 2023
## [2.0.0](v1.0.0...v2.0.0) (2023-03-22)

### ⚠ BREAKING CHANGES

* replace err-code with CodeError (#13)

### Bug Fixes

* replace err-code with CodeError ([#13](#13)) ([957f2f6](957f2f6))

### Trivial Changes

* Update .github/workflows/semantic-pull-request.yml [skip ci] ([f6e2f94](f6e2f94))
* Update .github/workflows/semantic-pull-request.yml [skip ci] ([7ce9f67](7ce9f67))
* Update .github/workflows/semantic-pull-request.yml [skip ci] ([c9a7099](c9a7099))
* Update .github/workflows/stale.yml [skip ci] ([df4e752](df4e752))
@github-actions
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants