This repository has been archived by the owner on Apr 8, 2020. It is now read-only.
Adds id() method to Secp256k1PrivateKey #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is blocking libp2p/js-libp2p-keychain#30 |
AlbertoElias
force-pushed
the
patch-1
branch
from
2645f9a to
994c78f
Compare
AlbertoElias
force-pushed
the
patch-1
branch
from
994c78f to
c9c90ee
Compare
|
Hey @dignifiedquire could you review please? |
|
@dignifiedquire great! I don't have write permissions. Could you merge and release? Thank you! |
|
@dignifiedquire can we get this merged and released? |
|
published, as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature parity with ed25519 and rsa