-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update deps #9
Conversation
Needed for next js-ipfs release. Had to port some changes from #7 Depends on: * [ ] ipfs-inactive/js-ipfs-http-client#1039 cc @achingbrain License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
@jacobheun I could use some help here. The tests are now failing because Previously it was returning values for all messages with a What is the right thing to do here? Do we need a streaming |
@alanshaw fyi, i pushed up a lint fix. Taking a look at the tests |
We only care about actual providers, I don't think we need to care about the extra information. It looks like the tests will need to be updated |
I'll update #7 once the dust settles on this. |
The provide/findProv calls are really inconsistent, looking into it more. |
test: update tests to use latest api fix License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
@alanshaw this should be fixed with ipfs-inactive/js-ipfs-http-client#1041. The test failures on CI are due to ipfsd-ctl resolving the current version of the http client instead of the fixed branch. Patching that locally makes the tests here pass every time. |
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
@jacobheun it still fails 🙀 |
@alanshaw clearing the node_modules cache on CI and rerunning to see if it's just an issue with the transitive deps cacheing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All better, it was ipfsd-ctl also using ipfs-http-client that was causing the issue. Blasting the cache allowed the fix to be all fix-y like.
Needed for next js-ipfs release. Had to port some changes from #7
Depends on:
cc @achingbrain