Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps #9

Merged
merged 8 commits into from
Jul 11, 2019
Merged

chore: update deps #9

merged 8 commits into from
Jul 11, 2019

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Jul 10, 2019

Needed for next js-ipfs release. Had to port some changes from #7

Depends on:

cc @achingbrain

Alan Shaw and others added 2 commits July 10, 2019 11:46
Needed for next js-ipfs release. Had to port some changes from #7

Depends on:

* [ ] ipfs-inactive/js-ipfs-http-client#1039

cc @achingbrain

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Jacob Heun <jacobheun@gmail.com>
@alanshaw
Copy link
Member Author

@jacobheun I could use some help here.

The tests are now failing because findProvs in ipfs-http-client now only returns values for messages where the Type is 4 (Provider).

Previously it was returning values for all messages with a Responses array because ipfs-api did not do any filtering on the Type.

What is the right thing to do here? Do we need a streaming findProvs so you can get hold of this extra info?

@jacobheun
Copy link
Contributor

@alanshaw fyi, i pushed up a lint fix.

Taking a look at the tests

@jacobheun
Copy link
Contributor

What is the right thing to do here? Do we need a streaming findProvs so you can get hold of this extra info?

We only care about actual providers, I don't think we need to care about the extra information. It looks like the tests will need to be updated

@achingbrain
Copy link
Member

I'll update #7 once the dust settles on this.

@jacobheun
Copy link
Contributor

The provide/findProv calls are really inconsistent, looking into it more.

Alan Shaw and others added 2 commits July 10, 2019 15:22
test: update tests to use latest api fix

License: MIT
Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT
Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT
Signed-off-by: Jacob Heun <jacobheun@gmail.com>
@jacobheun
Copy link
Contributor

@alanshaw this should be fixed with ipfs-inactive/js-ipfs-http-client#1041. The test failures on CI are due to ipfsd-ctl resolving the current version of the http client instead of the fixed branch. Patching that locally makes the tests here pass every time.

jacobheun and others added 2 commits July 11, 2019 11:41
License: MIT
Signed-off-by: Jacob Heun <jacobheun@gmail.com>
@alanshaw
Copy link
Member Author

@jacobheun it still fails 🙀

@jacobheun
Copy link
Contributor

@alanshaw clearing the node_modules cache on CI and rerunning to see if it's just an issue with the transitive deps cacheing.

Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All better, it was ipfsd-ctl also using ipfs-http-client that was causing the issue. Blasting the cache allowed the fix to be all fix-y like.

@jacobheun jacobheun merged commit bf06758 into master Jul 11, 2019
@jacobheun jacobheun deleted the chore/update-deps-20190710 branch July 11, 2019 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants