This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
feat!: rename peer discovery symbol to peerDiscovery #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The export `symbol` from the `@libp2p/interface-peer-discovery` is too generic to use with modules that might implement peer discovery and something else so it's been renamed to `peerDiscovery`. Objects with `peerDiscovery` symbol properties getters should return `PeerDiscovery` instances instead of `boolean` values. BREAKING CHANGE: the `symbol` export is now named `peerDiscovery`
github-actions bot
pushed a commit
that referenced
this pull request
May 4, 2023
## [@libp2p/interface-peer-discovery-v2.0.0](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-peer-discovery-v1.1.1...@libp2p/interface-peer-discovery-v2.0.0) (2023-05-04) ### ⚠ BREAKING CHANGES * the `symbol` export is now named `peerDiscovery` and the getter with that name should return an instance of `PeerDiscovery` ### Features * rename peer discovery symbol to peerDiscovery ([#394](#394)) ([5957c77](5957c77))
|
🎉 This PR is included in version @libp2p/interface-peer-discovery-v2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
May 4, 2023
## [@libp2p/interface-mocks-v12.0.0](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-mocks-v11.0.3...@libp2p/interface-mocks-v12.0.0) (2023-05-04) ### ⚠ BREAKING CHANGES * the `symbol` export is now named `peerDiscovery` and the getter with that name should return an instance of `PeerDiscovery` ### Features * rename peer discovery symbol to peerDiscovery ([#394](#394)) ([5957c77](5957c77)) ### Dependencies * update sibling dependencies ([45cf513](45cf513))
|
🎉 This PR is included in version @libp2p/interface-mocks-v12.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The export
symbolfrom the@libp2p/interface-peer-discoveryis too generic to use with modules that might implement peer discovery and something else so it's been renamed topeerDiscovery.Objects with
peerDiscoverysymbol properties getters should returnPeerDiscoveryinstances instead ofbooleanvalues.BREAKING CHANGE: the
symbolexport is now namedpeerDiscovery