Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

chore: update to new multiformats #98

Merged
merged 7 commits into from
Jul 6, 2021

Conversation

achingbrain
Copy link
Member

Replaces the cids, multihashes and multibase modules with the
new multiformats module.

BREAKING CHANGE: uses the CID class from the new multiformats module and pubsub.getMsgId became async

Replaces the `cids`, `multihashes` and `multibase` modules with the
new multiformats module.

BREAKING CHANGE: uses the CID class from the new multiformats module and pubsub.getMsgId became async
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending the final releases

src/pubsub/message/sign.js Outdated Show resolved Hide resolved
Co-authored-by: Vasco Santos <vasco.santos@moxy.studio>
@vasco-santos
Copy link
Member

Pointing out that there is a browser issue in CI

@achingbrain achingbrain marked this pull request as ready for review July 6, 2021 13:09
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vasco-santos vasco-santos merged commit 242027c into master Jul 6, 2021
@vasco-santos vasco-santos deleted the chore/update-to-new-multiformats branch July 6, 2021 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants