This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
feat: allow passing ProvidersInit in KadDHT constructor #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
suggested changes
Nov 29, 2022
achingbrain
approved these changes
Dec 7, 2022
achingbrain
reviewed
Dec 7, 2022
|
Thanks! |
|
🎉 This PR is included in version 6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Providerscomponent takes aProvidersInitobject, but there's not actually a way to provide it with one from theKadDHTconstructor. This means users aren't able to override the defaults for how long provider records are valid for and how frequently to clean up expired provider records.Feel free to close this if there's a different way you'd rather do it, or if for some reason it's not allowed on purpose (though I can't imagine why), but it's such a small change I thought I'd just open it as a PR.
Thanks for your time; this would really help me out!