This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
fix: correct KBucketTree types
#426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the `k-bucket` documentation [here](https://github.com/tristanls/k-bucket/blob/master/README.md#kbuckettoiterable) indicates, `toIterable` yields contact objects, **not** `KBucket` objects. Here, the contact objects are `KBucketPeer` objects. You can check this in the code [here](https://github.com/tristanls/k-bucket/blob/3aa5b4f1dacb835752995a25409ab319d2070b9e/index.js#L413) - the delegated yield `yield * node.contacts` will yield each of the elements of the `node.contacts` array in order.
achingbrain
approved these changes
Mar 10, 2023
|
Thanks! |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
## [7.0.1](v7.0.0...v7.0.1) (2023-03-10) ### Bug Fixes * correct `KBucketTree` types ([#426](#426)) ([ea8e6d0](ea8e6d0)), closes [/github.com/tristanls/k-bucket/blob/3aa5b4f1dacb835752995a25409ab319d2070b9e/index.js#L413](https://github.com/libp2p//github.com/tristanls/k-bucket/blob/3aa5b4f1dacb835752995a25409ab319d2070b9e/index.js/issues/L413) * update p-queue types ([#428](#428)) ([f5b85fc](f5b85fc)) ### Trivial Changes * replace err-code with CodeError ([#413](#413)) ([e05d2a0](e05d2a0)), closes [js-libp2p#1269](libp2p/js-libp2p#1269) * Update .github/workflows/semantic-pull-request.yml [skip ci] ([a70ab3f](a70ab3f)) * Update .github/workflows/semantic-pull-request.yml [skip ci] ([1652c6c](1652c6c)) * Update .github/workflows/semantic-pull-request.yml [skip ci] ([ea13c2a](ea13c2a))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the
k-bucketdocumentation here indicates,toIterableyields contact objects, notKBucketobjects. Here, the contact objects areKBucketPeerobjects.You can check this in the code here - the delegated yield
yield * node.contactswill yield each of the elements of thenode.contactsarray in order.