Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

feat: added bigint formatting #37

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maschad
Copy link
Member

@maschad maschad commented Jun 9, 2023

@achingbrain
Copy link
Member

I'm surprised this doesn't work out of the box with %s - what happens when you use that formatter?

@maschad
Copy link
Member Author

maschad commented Jun 15, 2023

It works in that it prints

  libp2p:perf:trace sending 1000000000000000n bytes 

but I think it's a bit more readable to print

  libp2p:perf:trace sending 1,000,000,000,000,000 bytes

hence this PR.

@MarcoPolo
Copy link

We lose the ability to copy/paste this value. Do we want to keep that?

@maschad
Copy link
Member Author

maschad commented Jun 28, 2023

We lose the ability to copy/paste this value. Do we want to keep that?

I wouldn't say so, if that's the intention consumers could pass the %s string as @achingbrain mentioned.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants