Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

apply mdns discovery fixes from the latest spec #101

Closed
lidel opened this issue Nov 6, 2021 · 2 comments · Fixed by #157
Closed

apply mdns discovery fixes from the latest spec #101

lidel opened this issue Nov 6, 2021 · 2 comments · Fixed by #157
Assignees
@mpetrunic
Labels
exp/intermediate Prior experience is likely helpful kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up released

Comments

@lidel
Copy link
Member

lidel commented Nov 6, 2021

@lidel lidel changed the title update new implementation to match the spec with recent fixes apply mdns discovery fixes from the latest spec Nov 6, 2021
@lidel lidel added exp/intermediate Prior experience is likely helpful kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up labels Feb 18, 2022
@mpetrunic mpetrunic mentioned this issue Oct 6, 2022
Closed
@mpetrunic
Copy link
Member

mpetrunic commented Oct 6, 2022 •
edited
Loading

We should:

  • add support for addresses other than ipv4/ipv6 (sending and parsing)
  • change the service name to _p2p._udp.local
  • change peer name to be randomly generated

cc @achingbrain

@tinytb tinytb moved this to Backlog in js-libp2p Oct 11, 2022
@tinytb tinytb added this to js-libp2p Oct 11, 2022
@tinytb tinytb moved this to Weekly Candidates in IP JS (PL EngRes) v2 Oct 14, 2022
@mpetrunic mpetrunic mentioned this issue Nov 8, 2022
Closed
@mpetrunic mpetrunic moved this from Backlog to Weekly Candidates/Discuss in js-libp2p Nov 29, 2022
@mpetrunic mpetrunic mentioned this issue Nov 29, 2022
Merged
@mpetrunic mpetrunic moved this from Weekly Candidates/Discuss to In Review in js-libp2p Nov 29, 2022
@mpetrunic mpetrunic self-assigned this Dec 5, 2022
@p-shahi p-shahi removed this from js-libp2p Dec 6, 2022
achingbrain added a commit that referenced this issue Mar 7, 2023
@mpetrunic @achingbrain
feat!: update to latest spec, added peer name, announces all multiadd…
5edcc16 
…rs (#157)

BREAKING CHANGE: service name now defaults to `_p2p._udp.local` and no
longer uses A and AAA records -> replaced by TXT records

Added random peer name option

resolves #101

---------

Co-authored-by: Alex Potsides <alex@achingbrain.net>
@github-project-automation github-project-automation bot moved this from Next to Done in IP JS (PL EngRes) v2 Mar 7, 2023
github-actions bot pushed a commit that referenced this issue Mar 7, 2023
@semantic-release-bot
chore(release): 7.0.0 [skip ci]
124fd47 
## [7.0.0](v6.0.0...v7.0.0) (2023-03-07)

### ⚠ BREAKING CHANGES

* service name now defaults to `_p2p._udp.local` and no
longer uses A and AAA records -> replaced by TXT records

Added random peer name option

### Features

* update to latest spec, added peer name, announces all multiaddrs ([#157](#157)) ([5edcc16](5edcc16)), closes [#101](#101)

### Trivial Changes

* Update .github/workflows/semantic-pull-request.yml [skip ci] ([28c668e](28c668e))
* Update .github/workflows/semantic-pull-request.yml [skip ci] ([9dccd84](9dccd84))
* upgrade aegir to `38.1.2`  ([#182](#182)) ([f86328c](f86328c))
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mpetrunic mpetrunic

Labels
exp/intermediate Prior experience is likely helpful kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: update to latest spec, added peer name, announces all multiaddrs libp2p/js-libp2p-mdns
2 participants
@lidel @mpetrunic