Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

chore: upgrade deps #97

Merged
merged 2 commits into from
Aug 11, 2020
Merged

chore: upgrade deps #97

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c90b71
chore: upgrade deps
achingbrain Aug 10, 2020
76464ac
chore: address pr comments
achingbrain Aug 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,17 @@
"homepage": "https://github.com/libp2p/js-libp2p-mdns",
"devDependencies": {
"aegir": "^25.0.0",
"chai": "^4.2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dep check is failing with chai removed, there must be some remaining usages of it.

"delay": "^4.3.0",
"dirty-chai": "^2.0.1",
"libp2p-interfaces": "^0.3.0",
"libp2p-interfaces": "^0.4.0",
"p-defer": "^3.0.0",
"p-wait-for": "^3.1.0"
},
"dependencies": {
"buffer": "^5.6.0",
"debug": "^4.1.1",
"multiaddr": "^7.5.0",
"multiaddr": "^8.0.0",
"multicast-dns": "^7.2.0",
"peer-id": "^0.13.13"
"peer-id": "^0.14.0"
},
"contributors": [
"David Dias <daviddias.p@gmail.com>",
Expand Down
1 change: 1 addition & 0 deletions src/compat/responder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ const OS = require('os')
const MDNS = require('multicast-dns')
const log = require('debug')('libp2p:mdns:compat:responder')
const { SERVICE_TAG_LOCAL } = require('./constants')
const { Buffer } = require('buffer')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for including buffer? mdns only works in Node, so Buffer should always be available.


class Responder {
constructor ({ peerId, multiaddrs }) {
Expand Down
5 changes: 1 addition & 4 deletions test/multicast-dns.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
/* eslint-env mocha */
'use strict'

const chai = require('chai')
const dirtyChai = require('dirty-chai')
const expect = chai.expect
chai.use(dirtyChai)
const { expect } = require('aegir/utils/chai')
const multiaddr = require('multiaddr')
const PeerId = require('peer-id')
const pWaitFor = require('p-wait-for')
Expand Down