This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
feat: limit internal message buffer size #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new config option `maxStreamBufferSize` which controls how large the input message buffer for a multiplexed stream is allowed to grow - defaults to 4MB [similar to go-mplex](https://github.com/libp2p/go-mplex/blob/master/multiplex.go#L26). If a stream handler does not process messages fast enough and the input buffer reaches this size, the stream will be reset and an error thrown to the handler. See option 2 in the [spec implementation notes](https://github.com/libp2p/specs/blob/master/mplex/README.md#implementation-notes).
achingbrain
force-pushed
the
feat/limit-internal-message-buffer-size
branch
from
50c8ebe
to
d34c2d1
Compare
wemeetagain
approved these changes
Jun 12, 2022
|
👍🏽 |
mpetrunic
approved these changes
Jun 13, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jun 13, 2022
## [1.2.0](v1.1.2...v1.2.0) (2022-06-13) ### Features * limit internal message buffer size ([#174](#174)) ([0c8e1b0](0c8e1b0)), closes [/github.com/libp2p/go-mplex/blob/master/multiplex.go#L26](https://github.com/libp2p//github.com/libp2p/go-mplex/blob/master/multiplex.go/issues/L26)
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new config option
maxStreamBufferSizewhich controls how large the input message buffer for a multiplexed stream is allowed to grow - defaults to 4MB similar to go-mplex.If a stream handler does not process messages fast enough and the input buffer reaches this size, the stream will be reset and an error thrown to the handler.
See option 2 in the spec implementation notes.