This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
fix: allow key field to be unset
#118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
suggested changes
Jan 31, 2023
Comment on lines
+102
to
103
| // @ts-expect-error key need not be defined | ||
| key: message.key |
There was a problem hiding this comment.
Instead of ts-expect-error, please verify that the key is present and correct - e.g. it should come from the message or the peer id, and if it's present in both the message and the peer id, they should be the same.
There was a problem hiding this comment.
Fixed. The @ts-expect-error has been retained since it should be nullable. The value of message.key is now verified in isSigned.
As far as secp256k1 or ed25519 keys are concerned, consider the current behaviour here. Since the public key is extractable, the msg.Key field is left unset, and the current js implementation considers this as an unsigned message.
achingbrain
changed the title
key field to be unsetkey field to be unset
github-actions bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
## [6.0.1](v6.0.0...v6.0.1) (2023-01-31) ### Bug Fixes * allow `key` field to be unset ([#118](#118)) ([2567a45](2567a45)) ### Trivial Changes * replace err-code with CodeError ([#116](#116)) ([e121e4b](e121e4b)), closes [js-libp2p#1269](libp2p/js-libp2p#1269)
|
🎉 This PR is included in version 6.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows field key to not be set in case key can be extracted from the sender's peer ID. (as per https://github.com/libp2p/specs/tree/master/pubsub#message-signing)