refactor: async #26

vasco-santos · 2019-08-30T10:21:44Z

BREAKING CHANGE: Switch to using async/await and async iterators.

Needs:

feat: topology js-libp2p-interfaces#7

BREAKING CHANGE: Switch to using async/await and async iterators.

vasco-santos · 2019-10-10T13:10:13Z

@jacobheun per our discussion earlier, I made the first iteration on the proposal for extracting the need for the libp2p instance in pubsub system.

Moreover, the dialing layer within pubsub/dht/... is intended to be removed, as we are currently duplicating a lot of dialing management within subsystems, like tracking dials and having dial queues, which could be controlled by js-libp2p / js-libp2p-connection-mgr.

https://gist.github.com/vasco-santos/2c39ab16d15a87c573bef4f916472831

I am not particularly convinced about the register side of things yet. First, I think we can have a better naming. Then, we can add other option features like autoDial (which I am going with default true right now), and connection management options (the subsystem can communicate js-libp2p meaningful numbers like the min/max number of connection in that protocol that it would like to have).

src/index.js

vasco-santos · 2019-10-15T12:25:08Z

src/index.js

+   * @param {function} registrar.unregister
+   * @param {Object} [options]
+   * @param {boolean} [options.signMessages] if messages should be signed, defaults to true
+   * @param {boolean} [options.strictSigning] if message signing should be required, defaults to true


My idea here is to add the topology to the options, which would overwrite the ones defined by the protocol. Should we do it here, or iterate the registrar topology in a following PR? My main concern is to add docs to stuff that we will not support yet

src/peer.js

vasco-santos · 2019-10-18T19:12:09Z

@jacobheun Already migrated this and did the same for floodsub and gossipsub. I will be working on the next couple of days of the PR to integrate this in js-libp2p

README.md

test/instance.spec.js

test/pubsub.spec.js

README.md

jacobheun · 2019-10-24T10:24:40Z

README.md

 }
 ```

+## API
+
+The following specified API should be the base API for a pubsub implementation on top of `libp2p`.


I don't quite follow this statement, is it necessary? How does this API related to https://github.com/ipfs/interface-js-ipfs-core/blob/master/SPEC/PUBSUB.md ?

It is not necessary. But, taking into account that we want to remove the pubsub function mapping from js-libp2p, and just keep it's instance there, all the implementations should provide the same API.

Regarding the ipfs spec one, I don't think the ls and peers API is understandable, and we already updated those in libp2p-daemon/libp2p-daemon-client. They will have to get that updated

Right now libp2p points to that API for docs, https://github.com/libp2p/js-libp2p#libp2ppubsub. We should either get the ipfs api corrected, or if we're looking to have a different API for libp2p, make sure we have appropriate doc references.

Being worked on libp2p/js-libp2p#467 and will also be pointed in this repo afterward

README.md

src/index.js

test/pubsub.spec.js

Co-Authored-By: Jacob Heun <jacobheun@gmail.com>

jacobheun

Overall this looks good, I noticed there aren't any tests yet for the new getPeersSubscribed. It might be good to add some to make sure we're getting back what we expect.

jacobheun

🚢 🚀

alanshaw mentioned this pull request Aug 30, 2019

Awesome Endeavour: Async Iterators ipfs/js-ipfs#1670

Closed

vasco-santos force-pushed the refactor/async branch 2 times, most recently from 8c85540 to 04f35c4 Compare September 3, 2019 15:43

vasco-santos force-pushed the refactor/async branch 3 times, most recently from 123c1ad to 44360e8 Compare October 4, 2019 09:52

refactor: async

9df6594

BREAKING CHANGE: Switch to using async/await and async iterators.

vasco-santos force-pushed the refactor/async branch from 44360e8 to 9df6594 Compare October 4, 2019 09:54

vasco-santos force-pushed the refactor/async branch 3 times, most recently from 6cf5a47 to 5e164c6 Compare October 15, 2019 10:42

vasco-santos commented Oct 15, 2019

View reviewed changes

src/index.js Show resolved Hide resolved

vasco-santos commented Oct 15, 2019

View reviewed changes

vasco-santos force-pushed the refactor/async branch from 5e164c6 to bac8bf3 Compare October 15, 2019 14:05

vasco-santos commented Oct 15, 2019

View reviewed changes

src/peer.js Outdated Show resolved Hide resolved

vasco-santos force-pushed the refactor/async branch 2 times, most recently from d31659e to f75548b Compare October 16, 2019 16:04

vasco-santos mentioned this pull request Oct 18, 2019

refactor: async migration ChainSafe/js-libp2p-gossipsub#49

Merged

3 tasks

vasco-santos force-pushed the refactor/async branch from f75548b to 97bfa5c Compare October 18, 2019 19:06

vasco-santos marked this pull request as ready for review October 18, 2019 19:10

vasco-santos requested a review from jacobheun October 18, 2019 19:11

vasco-santos mentioned this pull request Oct 18, 2019

refactor: switch to async iterators libp2p/js-libp2p-floodsub#88

Merged

1 task

jacobheun suggested changes Oct 21, 2019

View reviewed changes

feat: use registrar

f60da79

vasco-santos force-pushed the refactor/async branch from ec808e0 to f60da79 Compare October 21, 2019 16:07

jacobheun suggested changes Oct 24, 2019

View reviewed changes

vasco-santos force-pushed the refactor/async branch 2 times, most recently from a49d632 to 0b67775 Compare October 29, 2019 16:21

vasco-santos force-pushed the refactor/async branch 6 times, most recently from bbc18b7 to dc0b982 Compare October 30, 2019 16:45

chore: apply suggestions from code review

5b4f41b

Co-Authored-By: Jacob Heun <jacobheun@gmail.com>

vasco-santos force-pushed the refactor/async branch from dc0b982 to 5b4f41b Compare November 1, 2019 16:14

vasco-santos requested a review from jacobheun November 1, 2019 16:45

chore: address review

56ac766

vasco-santos force-pushed the refactor/async branch from afd1049 to 56ac766 Compare November 5, 2019 21:41

vasco-santos requested review from jacobheun and removed request for jacobheun November 12, 2019 16:36

vasco-santos force-pushed the refactor/async branch from 59c7850 to b187da7 Compare November 13, 2019 14:51

chore: add topology interface

4f94cd2

vasco-santos force-pushed the refactor/async branch from b187da7 to 4f94cd2 Compare November 14, 2019 11:09

vasco-santos requested review from jacobheun and removed request for jacobheun November 14, 2019 11:18

jacobheun reviewed Nov 14, 2019

View reviewed changes

chore: tests for getPeersSubscribed

f3cd195

jacobheun approved these changes Nov 14, 2019

View reviewed changes

vasco-santos merged commit c690b29 into master Nov 14, 2019

vasco-santos deleted the refactor/async branch November 14, 2019 13:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: async #26

refactor: async #26

vasco-santos commented Aug 30, 2019 •

edited

Loading

vasco-santos commented Oct 10, 2019

vasco-santos Oct 15, 2019

vasco-santos commented Oct 18, 2019

jacobheun Oct 24, 2019

vasco-santos Oct 28, 2019

jacobheun Oct 28, 2019

vasco-santos Nov 5, 2019

jacobheun left a comment

jacobheun left a comment

refactor: async #26

refactor: async #26

Conversation

vasco-santos commented Aug 30, 2019 • edited Loading

vasco-santos commented Oct 10, 2019

vasco-santos Oct 15, 2019

Choose a reason for hiding this comment

vasco-santos commented Oct 18, 2019

jacobheun Oct 24, 2019

Choose a reason for hiding this comment

vasco-santos Oct 28, 2019

Choose a reason for hiding this comment

jacobheun Oct 28, 2019

Choose a reason for hiding this comment

vasco-santos Nov 5, 2019

Choose a reason for hiding this comment

jacobheun left a comment

Choose a reason for hiding this comment

jacobheun left a comment

Choose a reason for hiding this comment

vasco-santos commented Aug 30, 2019 •

edited

Loading