This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
fix: use unidirectional streams #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
fix/use-unidirectional-streams
branch
from
08ac379
to
fa0f839
Compare
vasco-santos
force-pushed
the
fix/use-unidirectional-streams
branch
from
fa0f839
to
94d5c4d
Compare
This was referenced Jun 3, 2020
|
Per ipfs/kubo#7390 (comment) this should be ready to go |
vasco-santos
commented
Jun 3, 2020
| @@ -87,6 +87,8 @@ class Peer extends EventEmitter { | |||
| this.conn = conn | |||
| this.stream = pushable({ | |||
| onEnd: () => { | |||
| // close readable side of the stream | |||
| this.conn.reset && this.conn.reset() | |||
There was a problem hiding this comment.
As a follow-up, I will create an issue to remove this validation and create a wrapper around it-pair for these tests.
it-pair provides a bare minimal duplex stream for testing, but it does not have the reset function, as a multiplex stream. I tested this with js-libp2p and the stream reset function is called there.
achingbrain
approved these changes
Jun 3, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes libp2p pubsub subsystem use unidirectional streams instead of bidirectional streams per discussion on ipfs/go-ipfs#7390.
More details about the reasoning for this can be found in https://discuss.libp2p.io/t/gossip-questions/257/6