This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
refactor: convert from callbacks to async #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
force-pushed
the
feat/async-await
branch
from
d971398 to
4a4c0e3
Compare
dirkmc
changed the title
vasco-santos
suggested changes
Mar 4, 2019
There was a problem hiding this comment.
All in all, this looks great! Thanks @dirkmc
Just a minor request
vasco-santos
reviewed
Mar 6, 2019
BREAKING CHANGE: All places in the API that used callbacks are now replaced with async/await
chore: drop commitlint on travis
jacobheun
force-pushed
the
feat/async-await
branch
from
c6030e5 to
a0ee81c
Compare
jacobheun
changed the title
|
@dirkmc @vasco-santos I went ahead and updated the dependencies for this and rebased with master. This should be good to go. (Note: I believe this is the last blocker for the dht full migration) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: All places in the API that used callbacks are now replaced with async/await
Needs the following PRs:
Note that currently js-libp2p-crypto#131 depends on multihashing-async#master, whereas this PR depends on multihashing-async#37. So js-libp2p-crypto#131 will need to be updated to depend on multihashing-async#37 before this PR can be finished.